mirror of https://github.com/jacekkow/keycloak-protocol-cas

Bruno Oliveira da Silva
2018-09-13 d0daeb497f2d6a59f3c69f3d1bc6f75517c30925
Redirect URLs are not normalized
1 files modified
13 ■■■■■ changed files
src/main/java/org/keycloak/protocol/cas/utils/RedirectUtils.java 13 ●●●●● patch | view | raw | blame | history
src/main/java/org/keycloak/protocol/cas/utils/RedirectUtils.java
@@ -26,6 +26,7 @@
import javax.ws.rs.core.UriInfo;
import java.net.URI;
import java.net.URISyntaxException;
import java.util.Collection;
import java.util.HashSet;
import java.util.Set;
@@ -75,6 +76,10 @@
    }
    private static String verifyRedirectUri(UriInfo uriInfo, String rootUrl, String redirectUri, RealmModel realm, Set<String> validRedirects, boolean requireRedirectUri) {
        if (redirectUri != null)
            redirectUri = normalizeUrl(redirectUri);
        if (redirectUri == null) {
            if (!requireRedirectUri) {
                redirectUri = getSingleValidRedirectUri(validRedirects);
@@ -170,4 +175,12 @@
        return validRedirect;
    }
    private static String normalizeUrl(String url) {
        try {
            URI uri = new URI(url);
            return uri.normalize().toString();
        } catch (URISyntaxException e) {
            throw new IllegalArgumentException("Invalid URL syntax: " + e.getMessage());
        }
    }
}