mirror of https://github.com/jacekkow/keycloak-protocol-cas

Pedro Igor
2020-02-20 edac0ccc32848d4ecf3ae36264318ae4a92cf943
[KEYCLOAK-11576] - Properly handling redirect_uri parser errors
1 files modified
23 ■■■■ changed files
src/main/java/org/keycloak/protocol/cas/utils/RedirectUtils.java 23 ●●●● patch | view | raw | blame | history
src/main/java/org/keycloak/protocol/cas/utils/RedirectUtils.java
@@ -84,8 +84,18 @@
        KeycloakUriInfo uriInfo = session.getContext().getUri();
        RealmModel realm = session.getContext().getRealm();
        if (redirectUri != null)
            redirectUri = normalizeUrl(redirectUri);
        if (redirectUri != null) {
            try {
                URI uri = URI.create(redirectUri);
                redirectUri = uri.normalize().toString();
            } catch (IllegalArgumentException cause) {
                logger.debug("Invalid redirect uri", cause);
                return null;
            } catch (Exception cause) {
                logger.debug("Unexpected error when parsing redirect uri", cause);
                return null;
            }
        }
        if (redirectUri == null) {
            if (!requireRedirectUri) {
@@ -185,13 +195,4 @@
        }
        return validRedirect;
    }
    private static String normalizeUrl(String url) {
        try {
            URI uri = new URI(url);
            return uri.normalize().toString();
        } catch (URISyntaxException e) {
            throw new IllegalArgumentException("Invalid URL syntax: " + e.getMessage());
        }
    }
}