From 1cf376b3768c36548320e52b0d08391d75833af0 Mon Sep 17 00:00:00 2001 From: Matthias Piepkorn <mpiepk@gmail.com> Date: Tue, 14 Nov 2017 19:53:17 +0000 Subject: [PATCH] prepare next development version --- src/main/java/org/keycloak/protocol/cas/CASLoginProtocol.java | 44 ++++++++++++++++++++++++++++++++++---------- 1 files changed, 34 insertions(+), 10 deletions(-) diff --git a/src/main/java/org/keycloak/protocol/cas/CASLoginProtocol.java b/src/main/java/org/keycloak/protocol/cas/CASLoginProtocol.java index 8198a35..b796962 100644 --- a/src/main/java/org/keycloak/protocol/cas/CASLoginProtocol.java +++ b/src/main/java/org/keycloak/protocol/cas/CASLoginProtocol.java @@ -5,16 +5,20 @@ import org.keycloak.common.util.KeycloakUriBuilder; import org.keycloak.events.EventBuilder; import org.keycloak.events.EventType; +import org.keycloak.forms.login.LoginFormsProvider; import org.keycloak.models.*; import org.keycloak.protocol.LoginProtocol; import org.keycloak.protocol.cas.utils.LogoutHelper; import org.keycloak.services.managers.ClientSessionCode; import org.keycloak.services.managers.ResourceAdminManager; +import org.keycloak.sessions.AuthenticationSessionModel; +import org.keycloak.sessions.CommonClientSessionModel; import javax.ws.rs.core.HttpHeaders; import javax.ws.rs.core.Response; import javax.ws.rs.core.UriInfo; import java.io.IOException; +import java.lang.reflect.Method; import java.net.URI; public class CASLoginProtocol implements LoginProtocol { @@ -32,6 +36,8 @@ public static final String SERVICE_TICKET_PREFIX = "ST-"; public static final String SESSION_SERVICE_TICKET = "service_ticket"; + + public static final String LOGOUT_REDIRECT_URI = "CAS_LOGOUT_REDIRECT_URI"; protected KeycloakSession session; protected RealmModel realm; @@ -81,14 +87,24 @@ } @Override - public Response authenticated(UserSessionModel userSession, ClientSessionCode accessCode) { - ClientSessionModel clientSession = accessCode.getClientSession(); + public Response authenticated(UserSessionModel userSession, AuthenticatedClientSessionModel clientSession) { + ClientSessionCode<AuthenticatedClientSessionModel> accessCode = new ClientSessionCode<>(session, realm, clientSession); String service = clientSession.getRedirectUri(); //TODO validate service - accessCode.setAction(ClientSessionModel.Action.CODE_TO_TOKEN.name()); + + String code; + try { + // Keycloak >3.4 branch: Method getCode was renamed to getOrGenerateCode, CODE_TO_TOKEN was removed + Method getOrGenerateCode = ClientSessionCode.class.getMethod("getOrGenerateCode"); + code = (String) getOrGenerateCode.invoke(accessCode); + } catch (ReflectiveOperationException e) { + // Keycloak <=3.3 branch + accessCode.setAction(CommonClientSessionModel.Action.CODE_TO_TOKEN.name()); + code = accessCode.getCode(); + } KeycloakUriBuilder uriBuilder = KeycloakUriBuilder.fromUri(service); - uriBuilder.queryParam(TICKET_RESPONSE_PARAM, SERVICE_TICKET_PREFIX + accessCode.getCode()); + uriBuilder.queryParam(TICKET_RESPONSE_PARAM, SERVICE_TICKET_PREFIX + code); URI redirectUri = uriBuilder.build(); @@ -97,12 +113,12 @@ } @Override - public Response sendError(ClientSessionModel clientSession, Error error) { + public Response sendError(AuthenticationSessionModel authSession, Error error) { return Response.serverError().entity(error).build(); } @Override - public void backchannelLogout(UserSessionModel userSession, ClientSessionModel clientSession) { + public void backchannelLogout(UserSessionModel userSession, AuthenticatedClientSessionModel clientSession) { String logoutUrl = clientSession.getRedirectUri(); String serviceTicket = clientSession.getNote(CASLoginProtocol.SESSION_SERVICE_TICKET); //check if session is fully authenticated (i.e. serviceValidate has been called) @@ -124,21 +140,29 @@ } @Override - public Response frontchannelLogout(UserSessionModel userSession, ClientSessionModel clientSession) { + public Response frontchannelLogout(UserSessionModel userSession, AuthenticatedClientSessionModel clientSession) { // todo oidc redirect support throw new RuntimeException("NOT IMPLEMENTED"); } @Override public Response finishLogout(UserSessionModel userSession) { + String redirectUri = userSession.getNote(CASLoginProtocol.LOGOUT_REDIRECT_URI); + event.event(EventType.LOGOUT); event.user(userSession.getUser()).session(userSession).success(); - return Response.ok().build(); + LoginFormsProvider infoPage = session.getProvider(LoginFormsProvider.class).setSuccess("Logout successful"); + if (redirectUri != null) { + infoPage.setAttribute("pageRedirectUri", redirectUri); + } else { + infoPage.setAttribute("skipLink", true); + } + return infoPage.createInfoPage(); } @Override - public boolean requireReauthentication(UserSessionModel userSession, ClientSessionModel clientSession) { - return "true".equals(clientSession.getNote(CASLoginProtocol.RENEW_PARAM)); + public boolean requireReauthentication(UserSessionModel userSession, AuthenticationSessionModel authSession) { + return "true".equals(authSession.getClientNote(CASLoginProtocol.RENEW_PARAM)); } @Override -- Gitblit v1.9.1