From 352436410a73e70a8adffd8d5bfbd2bcdf97c139 Mon Sep 17 00:00:00 2001
From: Matthias Piepkorn <mpiepk@gmail.com>
Date: Sun, 29 Jan 2017 12:10:37 +0000
Subject: [PATCH] Improve serviceValidate error handling
---
src/test/java/org/keycloak/protocol/cas/ServiceResponseTest.java | 7 ++++---
1 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/src/test/java/org/keycloak/protocol/cas/ServiceResponseTest.java b/src/test/java/org/keycloak/protocol/cas/ServiceResponseTest.java
index 349c0c8..284a567 100644
--- a/src/test/java/org/keycloak/protocol/cas/ServiceResponseTest.java
+++ b/src/test/java/org/keycloak/protocol/cas/ServiceResponseTest.java
@@ -1,6 +1,7 @@
package org.keycloak.protocol.cas;
import org.junit.Test;
+import org.keycloak.protocol.cas.representations.CASErrorCode;
import org.keycloak.protocol.cas.representations.CasServiceResponse;
import org.keycloak.protocol.cas.utils.ServiceResponseHelper;
import org.keycloak.protocol.cas.utils.ServiceResponseMarshaller;
@@ -45,13 +46,13 @@
private static final String EXPECTED_JSON_FAILURE = "{\n" +
" \"serviceResponse\" : {\n" +
" \"authenticationFailure\" : {\n" +
- " \"code\" : \"ERROR_CODE\",\n" +
+ " \"code\" : \"INVALID_REQUEST\",\n" +
" \"description\" : \"Error description\"\n" +
" }\n" +
" }\n" +
"}";
private static final String EXPECTED_XML_FAILURE = "<cas:serviceResponse xmlns:cas=\"http://www.yale.edu/tp/cas\">\n" +
- " <cas:authenticationFailure code=\"ERROR_CODE\">Error description</cas:authenticationFailure>\n" +
+ " <cas:authenticationFailure code=\"INVALID_REQUEST\">Error description</cas:authenticationFailure>\n" +
"</cas:serviceResponse>";
@Test
@@ -70,7 +71,7 @@
@Test
public void testErrorResponse() throws Exception {
- CasServiceResponse response = ServiceResponseHelper.createFailure("ERROR_CODE", "Error description");
+ CasServiceResponse response = ServiceResponseHelper.createFailure(CASErrorCode.INVALID_REQUEST, "Error description");
assertEquals(EXPECTED_JSON_FAILURE, ServiceResponseMarshaller.marshalJson(response));
assertEquals(EXPECTED_XML_FAILURE, ServiceResponseMarshaller.marshalXml(response));
--
Gitblit v1.9.1