From fb26284c00e09e656732eb7ca4570afd052e0067 Mon Sep 17 00:00:00 2001
From: Jacek Kowalski <Jacek@jacekk.info>
Date: Fri, 21 Jun 2024 11:47:01 +0000
Subject: [PATCH] Improve error reporting in CAS ticket validation
---
src/main/java/org/keycloak/protocol/cas/CASLoginProtocolService.java | 37 ++++++++-----------------------------
1 files changed, 8 insertions(+), 29 deletions(-)
diff --git a/src/main/java/org/keycloak/protocol/cas/CASLoginProtocolService.java b/src/main/java/org/keycloak/protocol/cas/CASLoginProtocolService.java
index e8cbb39..8d8f944 100644
--- a/src/main/java/org/keycloak/protocol/cas/CASLoginProtocolService.java
+++ b/src/main/java/org/keycloak/protocol/cas/CASLoginProtocolService.java
@@ -1,12 +1,8 @@
package org.keycloak.protocol.cas;
import jakarta.ws.rs.Path;
-import jakarta.ws.rs.core.Context;
-import jakarta.ws.rs.core.HttpHeaders;
-import jakarta.ws.rs.core.Response;
import jakarta.ws.rs.core.UriBuilder;
-import org.jboss.resteasy.spi.HttpRequest;
-import org.jboss.resteasy.spi.ResteasyProviderFactory;
+
import org.keycloak.events.EventBuilder;
import org.keycloak.models.KeycloakSession;
import org.keycloak.models.RealmModel;
@@ -17,12 +13,6 @@
private KeycloakSession session;
private RealmModel realm;
private EventBuilder event;
-
- @Context
- private HttpHeaders headers;
-
- @Context
- private HttpRequest request;
public CASLoginProtocolService(KeycloakSession session, EventBuilder event) {
this.session = session;
@@ -36,48 +26,37 @@
@Path("login")
public Object login() {
- AuthorizationEndpoint endpoint = new AuthorizationEndpoint(session, event);
- ResteasyProviderFactory.getInstance().injectProperties(endpoint);
- return endpoint;
+ return new AuthorizationEndpoint(session, event);
}
@Path("logout")
public Object logout() {
- LogoutEndpoint endpoint = new LogoutEndpoint(realm);
- ResteasyProviderFactory.getInstance().injectProperties(endpoint);
- return endpoint;
+ return new LogoutEndpoint(session, realm);
}
@Path("validate")
public Object validate() {
- ValidateEndpoint endpoint = new ValidateEndpoint(realm, event);
- ResteasyProviderFactory.getInstance().injectProperties(endpoint);
- return endpoint;
+ return new ValidateEndpoint(session, realm, event);
}
@Path("samlValidate")
public Object validateSaml11() {
- SamlValidateEndpoint endpoint = new SamlValidateEndpoint(realm, event);
- ResteasyProviderFactory.getInstance().injectProperties(endpoint);
- return endpoint;
+ return new SamlValidateEndpoint(session, realm, event);
}
@Path("serviceValidate")
public Object serviceValidate() {
- ServiceValidateEndpoint endpoint = new ServiceValidateEndpoint(realm, event);
- ResteasyProviderFactory.getInstance().injectProperties(endpoint);
- return endpoint;
+ return new ServiceValidateEndpoint(session, realm, event);
}
@Path("proxyValidate")
public Object proxyValidate() {
- //TODO implement
- return serviceValidate();
+ return new ProxyValidateEndpoint(session, realm, event);
}
@Path("proxy")
public Object proxy() {
- return Response.serverError().entity("Not implemented").build();
+ return new ProxyEndpoint(session, realm, event);
}
@Path("p3/serviceValidate")
--
Gitblit v1.9.1