From 70cbe305478ffbf7644ddde461ce1eec71cb4a27 Mon Sep 17 00:00:00 2001 From: github-actions <41898282+github-actions[bot]@users.noreply.github.com> Date: Fri, 24 Feb 2023 08:47:40 +0000 Subject: [PATCH] Update to Keycloak 21.0.0 --- src/main/java/org/keycloak/protocol/cas/endpoints/AuthorizationEndpoint.java | 22 +++++++++++++++++++--- 1 files changed, 19 insertions(+), 3 deletions(-) diff --git a/src/main/java/org/keycloak/protocol/cas/endpoints/AuthorizationEndpoint.java b/src/main/java/org/keycloak/protocol/cas/endpoints/AuthorizationEndpoint.java index 865b937..90c34ae 100644 --- a/src/main/java/org/keycloak/protocol/cas/endpoints/AuthorizationEndpoint.java +++ b/src/main/java/org/keycloak/protocol/cas/endpoints/AuthorizationEndpoint.java @@ -35,6 +35,13 @@ public Response build() { MultivaluedMap<String, String> params = session.getContext().getUri().getQueryParameters(); String service = params.getFirst(CASLoginProtocol.SERVICE_PARAM); + + boolean isSaml11Request = false; + if (service == null && params.containsKey(CASLoginProtocol.TARGET_PARAM)) { + // SAML 1.1 authorization uses the TARGET parameter instead of service + service = params.getFirst(CASLoginProtocol.TARGET_PARAM); + isSaml11Request = true; + } boolean renew = params.containsKey(CASLoginProtocol.RENEW_PARAM); boolean gateway = params.containsKey(CASLoginProtocol.GATEWAY_PARAM); @@ -51,6 +58,13 @@ if (renew) { authenticationSession.setClientNote(CASLoginProtocol.RENEW_PARAM, "true"); } + if (gateway) { + authenticationSession.setClientNote(CASLoginProtocol.GATEWAY_PARAM, "true"); + } + if (isSaml11Request) { + // Flag the session so we can return the ticket as "SAMLart" in the response + authenticationSession.setClientNote(CASLoginProtocol.TARGET_PARAM, "true"); + } this.event.event(EventType.LOGIN); return handleBrowserAuthenticationRequest(authenticationSession, new CASLoginProtocol(session, realm, session.getContext().getUri(), headers, event), gateway, false); @@ -62,9 +76,11 @@ throw new ErrorPageException(session, Response.Status.BAD_REQUEST, Messages.MISSING_PARAMETER, CASLoginProtocol.SERVICE_PARAM); } - client = realm.getClients().stream() + event.detail(Details.REDIRECT_URI, service); + + client = realm.getClientsStream() .filter(c -> CASLoginProtocol.LOGIN_PROTOCOL.equals(c.getProtocol())) - .filter(c -> RedirectUtils.verifyRedirectUri(session.getContext().getUri(), service, realm, c) != null) + .filter(c -> RedirectUtils.verifyRedirectUri(session, service, c) != null) .findFirst().orElse(null); if (client == null) { event.error(Errors.CLIENT_NOT_FOUND); @@ -76,7 +92,7 @@ throw new ErrorPageException(session, Response.Status.BAD_REQUEST, Messages.CLIENT_DISABLED); } - redirectUri = RedirectUtils.verifyRedirectUri(session.getContext().getUri(), service, realm, client); + redirectUri = RedirectUtils.verifyRedirectUri(session, service, client); event.client(client.getClientId()); event.detail(Details.REDIRECT_URI, redirectUri); -- Gitblit v1.9.1