From 7107939d1228f1066cdfc478297127856c2ad49a Mon Sep 17 00:00:00 2001
From: Jacek Kowalski <jkowalsk@student.agh.edu.pl>
Date: Thu, 03 Sep 2015 17:13:09 +0000
Subject: [PATCH] Extract hardcoded session variable name to separate field
---
uphpCAS.php | 22 +++++++++++++++++-----
1 files changed, 17 insertions(+), 5 deletions(-)
diff --git a/uphpCAS.php b/uphpCAS.php
index b757153..bf6ab6a 100644
--- a/uphpCAS.php
+++ b/uphpCAS.php
@@ -13,8 +13,9 @@
const VERSION = '1.0';
protected $serverUrl = '';
protected $serviceUrl;
+ protected $sessionName = 'uphpCAS-user';
- function __construct($serverUrl = NULL, $serviceUrl = NULL) {
+ function __construct($serverUrl = NULL, $serviceUrl = NULL, $sessionName = NULL) {
if($serverUrl != NULL) {
$this->serverUrl = rtrim($serverUrl, '/');
}
@@ -44,6 +45,10 @@
$this->serviceUrl = $url;
}
+
+ if($sessionName) {
+ $this->sessionName = $sessionName;
+ }
}
public function getServerUrl() {
@@ -60,6 +65,13 @@
$this->serviceUrl = $serviceUrl;
}
+ public function getSessionName($sessionName) {
+ return $this->sessionName;
+ }
+ public function setSessionName($sessionName) {
+ $this->sessionName = $sessionName;
+ }
+
public function loginUrl() {
return $this->serverUrl.'/login?method=POST&service='.urlencode($this->serviceUrl);
}
@@ -71,7 +83,7 @@
public function logout($returnUrl = NULL) {
session_start();
if($this->isAuthenticated()) {
- unset($_SESSION['uphpCAS-user']);
+ unset($_SESSION[$this->sessionName]);
header('Location: '.$this->logoutUrl($returnUrl));
die();
} elseif($returnUrl) {
@@ -81,16 +93,16 @@
}
public function isAuthenticated() {
- return isset($_SESSION['uphpCAS-user']);
+ return isset($_SESSION[$this->sessionName]);
}
public function authenticate() {
session_start();
if($this->isAuthenticated()) {
- return $_SESSION['uphpCAS-user'];
+ return $_SESSION[$this->sessionName];
} elseif(isset($_REQUEST['ticket'])) {
$user = $this->verifyTicket($_REQUEST['ticket']);
- $_SESSION['uphpCAS-user'] = $user;
+ $_SESSION[$this->sessionName] = $user;
return $user;
} else {
header('Location: '.$this->loginUrl());
--
Gitblit v1.9.1