From 7b702660ef52338b3c14c1310f53d43cd346ccac Mon Sep 17 00:00:00 2001 From: Jacek Kowalski <Jacek@jacekk.info> Date: Fri, 21 Jun 2019 11:27:37 +0000 Subject: [PATCH] Add DB caching and make mapping independent on numToType --- parse.php | 78 +++++++++++++++++++++++++-------------- 1 files changed, 50 insertions(+), 28 deletions(-) diff --git a/parse.php b/parse.php index f438ba6..9e66121 100644 --- a/parse.php +++ b/parse.php @@ -2,42 +2,70 @@ require_once(__DIR__.'/lib/database.php'); require_once(__DIR__.'/lib/fetch.php'); require_once(__DIR__.'/lib/mapper.php'); - -$logger = new Monolog\Logger('Parse changes'); +require_once(__DIR__.'/lib/vehicle_types.php'); $sources = [ - 'buses' => [ - 'gtfs' => 'ftp://ztp.krakow.pl/VehiclePositions_A.pb', - 'gtfs_file' => 'VehiclePositions_A.pb', - 'ttss' => 'http://91.223.13.70/internetservice/geoserviceDispatcher/services/vehicleinfo/vehicles', + 'bus' => [ + 'gtfsrt' => 'ftp://ztp.krakow.pl/VehiclePositions_A.pb', + 'gtfsrt_file' => 'VehiclePositions_A.pb', + 'ttss' => 'http://ttss.mpk.krakow.pl/internetservice/geoserviceDispatcher/services/vehicleinfo/vehicles', 'ttss_file' => 'vehicles_A.json', 'database' => 'mapping_A.sqlite3', 'result' => 'mapping_A.json', + 'mapper' => 'numToTypeB', + ], + 'tram' => [ + 'gtfsrt' => 'ftp://ztp.krakow.pl/VehiclePositions_T.pb', + 'gtfsrt_file' => 'VehiclePositions_T.pb', + 'ttss' => 'http://www.ttss.krakow.pl/internetservice/geoserviceDispatcher/services/vehicleinfo/vehicles', + 'ttss_file' => 'vehicles_T.json', + 'database' => 'mapping_T.sqlite3', + 'result' => 'mapping_T.json', + 'mapper' => 'numToTypeT', + ], + 'tram2' => [ + 'gtfsrt' => 'ftp://ztp.krakow.pl/VehiclePositions.pb', + 'gtfsrt_file' => 'VehiclePositions_T.pb', + 'ttss' => 'http://www.ttss.krakow.pl/internetservice/geoserviceDispatcher/services/vehicleinfo/vehicles', + 'ttss_file' => 'vehicles_T.json', + 'database' => 'mapping_T.sqlite3', + 'result' => 'mapping_T.json', + 'mapper' => 'numToTypeT', ], ]; foreach($sources as $name => $source) { $logger = new Monolog\Logger('fetch_'.$name); try { - foreach(['gtfs_file', 'ttss_file', 'database', 'result'] as $field) { + foreach(['gtfsrt_file', 'ttss_file', 'database', 'result'] as $field) { $source[$field] = __DIR__.'/data/'.$source[$field]; } $source['result_temp'] = $source['result'].'.tmp'; $logger->info('Fetching '.$name.' position data from FTP...'); - $updated = ftp_fetch_if_newer($source['gtfs'], $source['gtfs_file']); + $updated = ftp_fetch_if_newer($source['gtfsrt'], $source['gtfsrt_file']); if(!$updated) { $logger->info('Nothing to do, remote file not newer than local one'); continue; } - $logger->info('Fetching '.$name.' positions from TTSS...'); - fetch($source['ttss'],$source['ttss_file']); + $logger->info('Fetching '.$name.' position data from TTSS...'); + fetch($source['ttss'], $source['ttss_file']); $logger->info('Loading data...'); $mapper = new Mapper(); + $mapper->loadTTSS($source['ttss_file']); - $mapper->loadGTFS($source['gtfs_file']); + $timeDifference = time() - $mapper->getTTSSDate(); + if(abs($timeDifference) > 120) { + throw new Exception('TTSS timestamp difference ('.$timeDifference.'s) is too high, aborting!'); + } + + $mapper->loadGTFSRT($source['gtfsrt_file']); + $timeDifference = time() - $mapper->getGTFSRTDate(); + if(abs($timeDifference) > 120) { + throw new Exception('GTFSRT timestamp difference ('.$timeDifference.'s) is too high, aborting!'); + } $db = new Database($source['database']); @@ -48,7 +76,7 @@ } $logger->info('Got offset '.$offset.', creating mapping...'); - $mapping = $mapper->getMapping($offset); + $mapping = $mapper->mapUsingOffset($offset); $logger->info('Checking the data for correctness...'); $weight = count($mapping); @@ -57,11 +85,11 @@ $incorrect = 0; $old = 0; $maxWeight = 0; - foreach($mapping as $id => $vehicle) { + foreach($mapping as $id => $num) { $dbVehicle = $db->getById($id); if($dbVehicle) { - $maxWeight = max($maxWeight, $dbVehicle['weight']); - if((int)substr($vehicle['num'], 2) == (int)$dbVehicle['num']) { + $maxWeight = max($maxWeight, (int)$dbVehicle['weight']); + if($num === $dbVehicle['num']) { $correct += 1; } else { $incorrect += 1; @@ -69,32 +97,26 @@ continue; } - $dbVehicle = $db->getByNum($vehicle['num']); - if($dbVehicle && $dbVehicle['id'] != $id) { + $dbVehicle = $db->getByNum($num); + if($dbVehicle && $dbVehicle['id'] !== $id) { $old += 1; } } + $logger->info('Weight: '.$weight.', correct: '.$correct.', incorrect: '.$incorrect.', old: '.$old); - $previousMapping = NULL; if($incorrect > $correct && $maxWeight > $weight) { throw new Exception('Ignoring result due to better data already present'); - } elseif($old > $correct) { - $logger->warn('Replacing DB data with the new mapping'); - $db->clear(); - } else { - $previousMapping = @json_decode(@file_get_contents($source['result']), TRUE); } $db->addMapping($mapping); - if(is_array($previousMapping)) { - $logger->info('Merging previous data with current mapping'); - $mapping = $mapping + $previousMapping; - ksort($mapping); + $jsonContent = []; + foreach($db->getAll() as $vehicle) { + $jsonContent[$vehicle['id']] = $source['mapper']($vehicle['num']); } - $json = json_encode($mapping); + $json = json_encode($jsonContent); if(!file_put_contents($source['result_temp'], $json)) { throw new Exception('Result save failed'); } -- Gitblit v1.9.1