From b6272077e75e77d7828ff5752e7ea7c9ec4942e8 Mon Sep 17 00:00:00 2001
From: Jacek Kowalski <Jacek@jacekk.info>
Date: Fri, 21 Jun 2019 11:45:13 +0000
Subject: [PATCH] Move configuration of data sources to a separate file (config.php)
---
parse.php | 63 ++++++++-----------------------
1 files changed, 16 insertions(+), 47 deletions(-)
diff --git a/parse.php b/parse.php
index 51e3132..148962d 100644
--- a/parse.php
+++ b/parse.php
@@ -1,39 +1,14 @@
<?php
+require_once(__DIR__.'/vendor/autoload.php');
require_once(__DIR__.'/lib/database.php');
require_once(__DIR__.'/lib/fetch.php');
require_once(__DIR__.'/lib/mapper.php');
-
-$logger = new Monolog\Logger('Parse changes');
-
-$sources = [
- 'bus' => [
- 'gtfsrt' => 'ftp://ztp.krakow.pl/VehiclePositions_A.pb',
- 'gtfsrt_file' => 'VehiclePositions_A.pb',
- 'ttss' => 'http://ttss.mpk.krakow.pl/internetservice/geoserviceDispatcher/services/vehicleinfo/vehicles',
- 'ttss_file' => 'vehicles_A.json',
- 'database' => 'mapping_A.sqlite3',
- 'result' => 'mapping_A.json',
- 'mapper' => 'numToTypeB',
- ],
- 'tram' => [
- 'gtfsrt' => 'ftp://ztp.krakow.pl/VehiclePositions.pb',
- 'gtfsrt_file' => 'VehiclePositions_T.pb',
- 'ttss' => 'http://www.ttss.krakow.pl/internetservice/geoserviceDispatcher/services/vehicleinfo/vehicles',
- 'ttss_file' => 'vehicles_T.json',
- 'database' => 'mapping_T.sqlite3',
- 'result' => 'mapping_T.json',
- 'mapper' => 'numToTypeT',
- ],
-];
+require_once(__DIR__.'/lib/vehicle_types.php');
+require_once(__DIR__.'/config.php');
foreach($sources as $name => $source) {
$logger = new Monolog\Logger('fetch_'.$name);
try {
- foreach(['gtfsrt_file', 'ttss_file', 'database', 'result'] as $field) {
- $source[$field] = __DIR__.'/data/'.$source[$field];
- }
- $source['result_temp'] = $source['result'].'.tmp';
-
$logger->info('Fetching '.$name.' position data from FTP...');
$updated = ftp_fetch_if_newer($source['gtfsrt'], $source['gtfsrt_file']);
if(!$updated) {
@@ -49,13 +24,13 @@
$mapper->loadTTSS($source['ttss_file']);
$timeDifference = time() - $mapper->getTTSSDate();
- if(abs($timeDifference) > 60) {
+ if(abs($timeDifference) > 120) {
throw new Exception('TTSS timestamp difference ('.$timeDifference.'s) is too high, aborting!');
}
$mapper->loadGTFSRT($source['gtfsrt_file']);
$timeDifference = time() - $mapper->getGTFSRTDate();
- if(abs($timeDifference) > 60) {
+ if(abs($timeDifference) > 120) {
throw new Exception('GTFSRT timestamp difference ('.$timeDifference.'s) is too high, aborting!');
}
@@ -68,7 +43,7 @@
}
$logger->info('Got offset '.$offset.', creating mapping...');
- $mapping = $mapper->mapUsingOffset($offset, $source['mapper']);
+ $mapping = $mapper->mapUsingOffset($offset);
$logger->info('Checking the data for correctness...');
$weight = count($mapping);
@@ -77,11 +52,11 @@
$incorrect = 0;
$old = 0;
$maxWeight = 0;
- foreach($mapping as $id => $vehicle) {
+ foreach($mapping as $id => $num) {
$dbVehicle = $db->getById($id);
if($dbVehicle) {
- $maxWeight = max($maxWeight, $dbVehicle['weight']);
- if((int)substr($vehicle['num'], 2) == (int)$dbVehicle['num']) {
+ $maxWeight = max($maxWeight, (int)$dbVehicle['weight']);
+ if($num === $dbVehicle['num']) {
$correct += 1;
} else {
$incorrect += 1;
@@ -89,32 +64,26 @@
continue;
}
- $dbVehicle = $db->getByNum($vehicle['num']);
- if($dbVehicle && $dbVehicle['id'] != $id) {
+ $dbVehicle = $db->getByNum($num);
+ if($dbVehicle && $dbVehicle['id'] !== $id) {
$old += 1;
}
}
+
$logger->info('Weight: '.$weight.', correct: '.$correct.', incorrect: '.$incorrect.', old: '.$old);
- $previousMapping = NULL;
if($incorrect > $correct && $maxWeight > $weight) {
throw new Exception('Ignoring result due to better data already present');
- } elseif($old > $correct) {
- $logger->warn('Replacing DB data with the new mapping');
- $db->clear();
- } else {
- $previousMapping = @json_decode(@file_get_contents($source['result']), TRUE);
}
$db->addMapping($mapping);
- if(is_array($previousMapping)) {
- $logger->info('Merging previous data with current mapping');
- $mapping = $mapping + $previousMapping;
- ksort($mapping);
+ $jsonContent = [];
+ foreach($db->getAll() as $vehicle) {
+ $jsonContent[$vehicle['id']] = $source['mapper']($vehicle['num']);
}
- $json = json_encode($mapping);
+ $json = json_encode($jsonContent);
if(!file_put_contents($source['result_temp'], $json)) {
throw new Exception('Result save failed');
}
--
Gitblit v1.9.1