From 7c2d04008df30360e5d9a2a53f42d77fa10757ea Mon Sep 17 00:00:00 2001
From: Jacek Kowalski <Jacek@jacekk.info>
Date: Sat, 17 Aug 2024 20:08:50 +0000
Subject: [PATCH] Implement a timeout on fetch request
---
parse.php | 83 +++++++++++++++++------------------------
1 files changed, 34 insertions(+), 49 deletions(-)
diff --git a/parse.php b/parse.php
index f438ba6..c54f19d 100644
--- a/parse.php
+++ b/parse.php
@@ -1,43 +1,34 @@
<?php
-require_once(__DIR__.'/lib/database.php');
-require_once(__DIR__.'/lib/fetch.php');
-require_once(__DIR__.'/lib/mapper.php');
-
-$logger = new Monolog\Logger('Parse changes');
-
-$sources = [
- 'buses' => [
- 'gtfs' => 'ftp://ztp.krakow.pl/VehiclePositions_A.pb',
- 'gtfs_file' => 'VehiclePositions_A.pb',
- 'ttss' => 'http://91.223.13.70/internetservice/geoserviceDispatcher/services/vehicleinfo/vehicles',
- 'ttss_file' => 'vehicles_A.json',
- 'database' => 'mapping_A.sqlite3',
- 'result' => 'mapping_A.json',
- ],
-];
+require_once(__DIR__.'/vendor/autoload.php');
+require_once(__DIR__.'/config.php');
foreach($sources as $name => $source) {
$logger = new Monolog\Logger('fetch_'.$name);
try {
- foreach(['gtfs_file', 'ttss_file', 'database', 'result'] as $field) {
- $source[$field] = __DIR__.'/data/'.$source[$field];
- }
- $source['result_temp'] = $source['result'].'.tmp';
-
- $logger->info('Fetching '.$name.' position data from FTP...');
- $updated = ftp_fetch_if_newer($source['gtfs'], $source['gtfs_file']);
+ $logger->info('Fetching '.$name.' GTFS position data ...');
+ $updated = Fetch::auto($source['gtfsrt'], $source['gtfsrt_file']);
if(!$updated) {
$logger->info('Nothing to do, remote file not newer than local one');
continue;
}
- $logger->info('Fetching '.$name.' positions from TTSS...');
- fetch($source['ttss'],$source['ttss_file']);
+ $logger->info('Fetching '.$name.' TTSS position data...');
+ Fetch::auto($source['ttss'], $source['ttss_file']);
$logger->info('Loading data...');
$mapper = new Mapper();
+
$mapper->loadTTSS($source['ttss_file']);
- $mapper->loadGTFS($source['gtfs_file']);
+ $timeDifference = time() - $mapper->getTTSSDate();
+ if(abs($timeDifference) > 120) {
+ throw new Exception('TTSS timestamp difference ('.$timeDifference.'s) is too high, aborting!');
+ }
+
+ $mapper->loadGTFSRT($source['gtfsrt_file']);
+ $timeDifference = time() - $mapper->getGTFSRTDate();
+ if(abs($timeDifference) > 120) {
+ throw new Exception('GTFSRT timestamp difference ('.$timeDifference.'s) is too high, aborting!');
+ }
$db = new Database($source['database']);
@@ -48,7 +39,7 @@
}
$logger->info('Got offset '.$offset.', creating mapping...');
- $mapping = $mapper->getMapping($offset);
+ $mapping = $mapper->mapVehicleIdsUsingOffset($offset);
$logger->info('Checking the data for correctness...');
$weight = count($mapping);
@@ -57,11 +48,11 @@
$incorrect = 0;
$old = 0;
$maxWeight = 0;
- foreach($mapping as $id => $vehicle) {
+ foreach($mapping as $id => $num) {
$dbVehicle = $db->getById($id);
if($dbVehicle) {
- $maxWeight = max($maxWeight, $dbVehicle['weight']);
- if((int)substr($vehicle['num'], 2) == (int)$dbVehicle['num']) {
+ $maxWeight = max($maxWeight, (int)$dbVehicle['weight']);
+ if($num === $dbVehicle['num']) {
$correct += 1;
} else {
$incorrect += 1;
@@ -69,36 +60,30 @@
continue;
}
- $dbVehicle = $db->getByNum($vehicle['num']);
- if($dbVehicle && $dbVehicle['id'] != $id) {
+ $dbVehicle = $db->getByNum($num);
+ if($dbVehicle && $dbVehicle['id'] !== $id) {
$old += 1;
}
}
+
$logger->info('Weight: '.$weight.', correct: '.$correct.', incorrect: '.$incorrect.', old: '.$old);
- $previousMapping = NULL;
if($incorrect > $correct && $maxWeight > $weight) {
throw new Exception('Ignoring result due to better data already present');
- } elseif($old > $correct) {
- $logger->warn('Replacing DB data with the new mapping');
- $db->clear();
- } else {
- $previousMapping = @json_decode(@file_get_contents($source['result']), TRUE);
}
- $db->addMapping($mapping);
+ $output = new Output($db, $mapper, $source['vehicle_types']);
- if(is_array($previousMapping)) {
- $logger->info('Merging previous data with current mapping');
- $mapping = $mapping + $previousMapping;
- ksort($mapping);
- }
+ $logger->info('Saving mapping...');
- $json = json_encode($mapping);
- if(!file_put_contents($source['result_temp'], $json)) {
- throw new Exception('Result save failed');
- }
- rename($source['result_temp'], $source['result']);
+ $db->addMapping($mapping, $mapper);
+
+ $fullMapping = $output->createMapping($source);
+
+ $logger->info('Creating vehicle list...');
+
+ $output->createVehiclesList($fullMapping, $source);
+
$logger->info('Finished');
} catch(Throwable $e) {
$logger->error($e->getMessage(), ['exception' => $e, 'exception_string' => (string)$e]);
--
Gitblit v1.9.1