From 7e722179b6df2f7c6d0fc68c3f1f374df230d774 Mon Sep 17 00:00:00 2001
From: Jacek Kowalski <Jacek@jacekk.info>
Date: Sat, 04 May 2019 14:50:08 +0000
Subject: [PATCH] Add Codacy badge and fix some errors reported by the checker
---
common.js | 73 +++++++++++++++++++-----------------
1 files changed, 39 insertions(+), 34 deletions(-)
diff --git a/common.js b/common.js
index b434bf1..fa006be 100644
--- a/common.js
+++ b/common.js
@@ -1,4 +1,4 @@
-"use strict";
+'use strict';
var ttss_urls = {
t: 'proxy_tram.php',
@@ -26,7 +26,7 @@
promise: promise,
request: request,
abort: function() {
- request.abort.bind(request)
+ request.abort.bind(request);
return Deferred(promise, request);
},
done: function(func) {
@@ -70,7 +70,7 @@
}
}
};
- request.open("GET", url, true);
+ request.open('GET', url, true);
request.send();
});
return Deferred(promise, request);
@@ -111,9 +111,42 @@
}
+/*******
+ * DOM *
+ *******/
+
+function deleteChildren(element) {
+ while(element.lastChild) element.removeChild(element.lastChild);
+}
+
+function addElementWithText(parent, element, text) {
+ var elem = document.createElement(element);
+ elem.appendChild(document.createTextNode(text));
+ parent.appendChild(elem);
+ return elem;
+}
+
+function addCellWithText(parent, text) {
+ return addElementWithText(parent, 'td', text);
+}
+
+function addParaWithText(parent, text) {
+ return addElementWithText(parent, 'p', text);
+}
+
+function setText(element, text) {
+ deleteChildren(element);
+ element.appendChild(document.createTextNode(text));
+}
+
+
/***********
* PARSING *
***********/
+
+function normalizeName(string) {
+ return string.replace('.', '. ').replace(' ', ' ');
+}
function parseStatus(status) {
switch(status.status) {
@@ -185,14 +218,15 @@
}
function depotIdToVehicleId(depotId, typeHelper) {
+ var prop;
if(typeHelper) {
- for(var prop in vehicles_info) {
+ for(prop in vehicles_info) {
if(prop.substr(0,1) == typeHelper && vehicles_info[prop]['num'].substr(2) == depotId) {
return prop;
}
}
} else {
- for(var prop in vehicles_info) {
+ for(prop in vehicles_info) {
if(vehicles_info[prop]['num'] == depotId) {
return prop;
}
@@ -224,33 +258,4 @@
.replace('$floor', floor_type);
return span;
-}
-
-
-/*******
- * DOM *
- *******/
-
-function deleteChildren(element) {
- while(element.lastChild) element.removeChild(element.lastChild);
-}
-
-function addElementWithText(parent, element, text) {
- var elem = document.createElement(element);
- elem.appendChild(document.createTextNode(text));
- parent.appendChild(elem);
- return elem;
-}
-
-function addCellWithText(parent, text) {
- return addElementWithText(parent, 'td', text);
-}
-
-function addParaWithText(parent, text) {
- return addElementWithText(parent, 'p', text);
-}
-
-function setText(element, text) {
- deleteChildren(element);
- element.appendChild(document.createTextNode(text));
}
--
Gitblit v1.9.1