From 7e722179b6df2f7c6d0fc68c3f1f374df230d774 Mon Sep 17 00:00:00 2001 From: Jacek Kowalski <Jacek@jacekk.info> Date: Sat, 04 May 2019 14:50:08 +0000 Subject: [PATCH] Add Codacy badge and fix some errors reported by the checker --- map.js | 18 ++++++++---------- 1 files changed, 8 insertions(+), 10 deletions(-) diff --git a/map.js b/map.js index c6f8bdc..d6b117c 100644 --- a/map.js +++ b/map.js @@ -1,4 +1,4 @@ -"use strict"; +'use strict'; var ttss_refresh = 10000; // 10 seconds var ttss_position_type = 'RAW'; @@ -228,7 +228,6 @@ var feature, prefix; for(var i = 0; i < stops.length; i++) { - feature = null; if(stops[i].getId) { feature = stops[i]; } else { @@ -310,8 +309,9 @@ function updateStopSource(stops, prefix) { var source = stops_source[prefix]; var mapping = stops_mapping[prefix]; + var stop; for(var i = 0; i < stops.length; i++) { - var stop = stops[i]; + stop = stops[i]; if(stop.category == 'other') continue; if(stops_ignored.includes(stop.shortName)) continue; @@ -347,7 +347,7 @@ }).fail(fail_ajax); } -function vehiclePath(feature, tripId) { +function vehiclePath(feature) { if(path_xhr) path_xhr.abort(); var featureId = feature.getId(); @@ -484,11 +484,8 @@ return; } - var coordinates = feature.getGeometry().getCoordinates(); - var div = document.createElement('div'); - var typeName; var name = normalizeName(feature.get('name')); var additional; var table = document.createElement('table'); @@ -628,6 +625,8 @@ if(feature.getId()) features.push(feature); }); + var feature = features[0]; + if(features.length > 1) { featureClicked(); @@ -635,7 +634,7 @@ addParaWithText(div, lang.select_feature); - var feature, p, a, full_type, typeName; + var p, a, full_type, typeName; for(var i = 0; i < features.length; i++) { feature = features[i]; @@ -664,7 +663,6 @@ return; } - var feature = features[0]; if(!feature) { stops_type.forEach(function(type) { if(stops_layer[type].getVisible()) { @@ -914,7 +912,7 @@ }); // Change layer visibility on zoom - var change_resolution = function(e) { + var change_resolution = function() { stops_type.forEach(function(type) { if(type.startsWith('p')) { stops_layer[type].setVisible(map.getView().getZoom() >= 16); -- Gitblit v1.9.1