From ebf0b71cb81db506b018a1da12edea635f605937 Mon Sep 17 00:00:00 2001
From: Jacek Kowalski <Jacek@jacekk.info>
Date: Wed, 14 Jun 2023 11:06:55 +0000
Subject: [PATCH] Add parameter/property type hints
---
src/UcrmHelper.php | 27 ++++++++++++++++-----------
1 files changed, 16 insertions(+), 11 deletions(-)
diff --git a/src/UcrmHelper.php b/src/UcrmHelper.php
index 9d709f1..830c923 100644
--- a/src/UcrmHelper.php
+++ b/src/UcrmHelper.php
@@ -3,10 +3,10 @@
namespace SIPL\UCRM\wFirma;
class UcrmHelper {
- protected $rootDirectory;
- protected $api = NULL;
- protected $attributes = NULL;
- protected $paymentMethods = NULL;
+ protected string $rootDirectory;
+ protected ?\Ubnt\UcrmPluginSdk\Service\UcrmApi $api = NULL;
+ protected ?UcrmAttributes $attributes = NULL;
+ protected ?UcrmPaymentMethods $paymentMethods = NULL;
protected $config = NULL;
protected $event = NULL;
@@ -17,32 +17,32 @@
$this->rootDirectory = $rootDirectory;
}
- function getRootDirectory() {
+ function getRootDirectory(): string {
return $this->rootDirectory;
}
- function getApi() {
+ function getApi(): \Ubnt\UcrmPluginSdk\Service\UcrmApi {
if ($this->api === NULL) {
$this->api = \Ubnt\UcrmPluginSdk\Service\UcrmApi::create($this->rootDirectory);
}
return $this->api;
}
- function getAttributes() {
+ function getAttributes(): UcrmAttributes {
if ($this->attributes === NULL) {
$this->attributes = new UcrmAttributes($this);
}
return $this->attributes;
}
- function getPaymentMethods() {
+ function getPaymentMethods(): UcrmPaymentMethods {
if ($this->paymentMethods === NULL) {
$this->paymentMethods = new UcrmPaymentMethods($this);
}
return $this->paymentMethods;
}
- function getConfig() {
+ function getConfig(): array {
if ($this->config === NULL) {
$configManager = \Ubnt\UcrmPluginSdk\Service\PluginConfigManager::create($this->rootDirectory);
$this->config = $configManager->loadConfig();
@@ -50,7 +50,12 @@
return $this->config;
}
- function getCurrentEvent() {
+ function getVersion(): string {
+ $response = $this->getApi()->get('/version');
+ return $response['version'];
+ }
+
+ function getCurrentEvent(): array {
if ($this->event === NULL) {
try {
if (($_SERVER['REQUEST_METHOD'] ?? '') !== 'POST') {
@@ -74,7 +79,7 @@
throw new \RuntimeException('Failed to process event - event not found');
}
- if (!is_int($event['entityId'])) {
+ if (!ctype_digit($event['entityId'])) {
throw new \RuntimeException('Failed to process event - invalid entity ID');
}
--
Gitblit v1.10.0